rolling.construct: Add sliding_window_view_kwargs to pipe arguments down to sliding_window_view
#9720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
force-pushed
the
rolling-auto-rechunk
branch
4 times, most recently
from
223390c
to
ae9e8c0
Compare
dcherian
force-pushed
the
rolling-auto-rechunk
branch
from
ae9e8c0
to
1bdd60b
Compare
|
I don't have much context here, but should we always do this if possible, rather than add an option? Or we want to allow an escape hatch for instances where copies are made? |
|
It is on by default in the public APIs ( I think we should expose it in |
|
No! Generally keen on keeping the API small but totally reasonable here! |
|
@max-sixty one option would be to add |
dcherian
changed the title
automatic_rechunk kwargrolling.construct: Add sliding_window_kwargs to pipe arguments down to sliding_window_view
dcherian
changed the title
rolling.construct: Add sliding_window_kwargs to pipe arguments down to sliding_window_viewrolling.construct: Add sliding_window_kwargs to pipe arguments down to sliding_window_view
* main: Compress PNG files (pydata#9747) Dispatch to Dask if nanquantile is available (pydata#9719)
|
I went with |
dcherian
added
needs review
topic-rolling
topic-chunked-arrays
4 tasks
|
@max-sixty any more thoughts here? |
* main: Add download stats badges (pydata#9786)
dcherian
changed the title
rolling.construct: Add sliding_window_kwargs to pipe arguments down to sliding_window_viewrolling.construct: Add sliding_window_view_kwargs to pipe arguments down to sliding_window_view
dcherian
added a commit
that referenced
this pull request
Nov 19, 2024
* main: (24 commits) Bump minimum versions (#9796) Namespace-aware `xarray.ufuncs` (#9776) Add prettier and pygrep hooks to pre-commit hooks (#9644) `rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (#9720) Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (#9793) Buffer types (#9787) Add download stats badges (#9786) Fix open_mfdataset for list of fsspec files (#9785) add 'User-Agent'-header to pooch.retrieve (#9782) Optimize `ffill`, `bfill` with dask when `limit` is specified (#9771) fix cf decoding of grid_mapping (#9765) Allow wrapping `np.ndarray` subclasses (#9760) Optimize polyfit (#9766) Use `map_overlap` for rolling reductions with Dask (#9770) fix html repr indexes section (#9768) Bump pypa/gh-action-pypi-publish from 1.11.0 to 1.12.2 in the actions group (#9763) unpin array-api-strict, as issues are resolved upstream (#9762) rewrite the `min_deps_check` script (#9754) CI runs ruff instead of pep8speaks (#9759) Specify copyright holders in main license file (#9756) ...
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Nov 19, 2024
* main: Bump minimum versions (pydata#9796) Namespace-aware `xarray.ufuncs` (pydata#9776) Add prettier and pygrep hooks to pre-commit hooks (pydata#9644) `rolling.construct`: Add `sliding_window_kwargs` to pipe arguments down to `sliding_window_view` (pydata#9720) Bump codecov/codecov-action from 4.6.0 to 5.0.2 in the actions group (pydata#9793) Buffer types (pydata#9787) Add download stats badges (pydata#9786) Fix open_mfdataset for list of fsspec files (pydata#9785) add 'User-Agent'-header to pooch.retrieve (pydata#9782) Optimize `ffill`, `bfill` with dask when `limit` is specified (pydata#9771) fix cf decoding of grid_mapping (pydata#9765) Allow wrapping `np.ndarray` subclasses (pydata#9760) Optimize polyfit (pydata#9766) Use `map_overlap` for rolling reductions with Dask (pydata#9770)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9550
xref #4325
whats-new.rstcc @phofl
Blocked till the next dask release, so we can verify tests